CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.

GNU General Public License v3.0

238 stars 90 forks source link

bump netty to 4.1.75 #374

Closed crafter23456 closed 2 years ago

crafter23456 commented 2 years ago

Description

Bumped the netty version to latest (4.7.0) & adjust the protocollib check.

Additional Comments

Merge this PR if you think its ready to move on. The switch to protocollib 4.7.0 to 4.8.0 doesnt need that much time and doesnt change things so everybody can simply upgrade.

Checklist:

[x] I have reviewed my code thoroughly.
[x] I have tested my code.
[x] My changes generate no new warnings

ghost commented 2 years ago

Not recommended to merge right now, we should wait the situation to be stable (ProtocolLib, PacketEvents, etc)

Sculas commented 2 years ago

Converted this to a draft until it is safe to merge.

CyberFlameGO commented 2 years ago

iirc every time we've tried to update netty, it's caused issues 💀

crafter23456 commented 2 years ago

It was everytime the problem because of people which use an old version. Now is Protocollib 4.8.0 on spigot and 5.0.0 (thanks klaro) as snapshot, both work well with netty 4.1.74. So we can wait a bit until the majority moves on and then command them to update. I mean it's only a drag and drop replacement and nothing else

ghost commented 2 years ago

I think it's time to merge this