CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.

GNU General Public License v3.0

237 stars 87 forks source link

Cleanup #396

Closed 128931 closed 2 years ago

128931 commented 2 years ago

Description

Cleaned up a decent amount of the API code to be up to Java 8 standards.

How has this been tested?

I have built the jar and ran it on localhost I saw no new errors/exceptions I joined and played mc for approx 10 mins doing various things an mc player would do and I saw nothing out of the ordinary happen

Additional Comments

This is my first time working on a spigot/fork of it so if I have changed something that would break a feature or something within spigot lmk

Checklist:

[x] I have reviewed my code thoroughly.
[x] I have tested my code.
[x] My changes generate no new warnings

128931 commented 2 years ago

Do you have benchmarkes to back this up? because that doesn't make sense to set them to zero, because that is a pretty big claim

JDK 8 Benchmark JDK 11-16 Benchmark despite it only going up to JDK 16 the JDK 17 Changelog hasn't really changed that much so zero-sized should still outperform pre-sized.

CyberFlameGO commented 2 years ago

I recall trying to update some of these myself; it broke many things

ytnoos commented 2 years ago

Why did you revert?

128931 commented 2 years ago

Why did you revert?

Classified information.

128931 commented 2 years ago

I would clean up the server directory rn but the code gives me nightmares due to it being decompiled code so I'll probably do it later

128931 commented 2 years ago

I'm gonna ignore cleaning up the NMS for a bit as I've looked thru some of the classes and I almost got traumatized looking at that decompiled code