CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 87 forks source link

Server crash #398

Open jamoeight opened 2 years ago

jamoeight commented 2 years ago

Observed Behavior

A random server crash comes with this error log not sure if this is related to NachoSpigot, https://paste.md-5.net/evezaregib.rb

Expected Behavior

Server not to crash

Steps To Reproduce

Dont know how it happens, has happened twice in 4 days, never happened on 1.8 TacoSpigot

Plugin List

No response

Server Version

Latest version of NachoSpigot on Java 17 https://gyazo.com/ae58de4e65c54e584172923bc3e2718d?token=0e2fc9783cc722fbad0decae050c6d52

Other

No additional info.

Agreements

crafter23456 commented 2 years ago

https://github.com/crafter23456/NachoSpigot/actions/runs/2098430011 try that. it might fix it. please tell if its working and I'll do a PR

ghost commented 2 years ago

https://github.com/crafter23456/NachoSpigot/actions/runs/2098430011 try that. it might fix it. please tell if its working and I'll do a PR

Looked at the commit and I’m pretty sure that causes a different problem

crafter23456 commented 2 years ago

https://github.com/crafter23456/NachoSpigot/actions/runs/2098430011 try that. it might fix it. please tell if its working and I'll do a PR

Looked at the commit and I’m pretty sure that causes a different problem

O.o here changed the big part https://github.com/CobbleSword/NachoSpigot/commit/eeb6efd979e8d30b18ec200638672e3064e2b80c and here changed lucas it to nextLong https://github.com/CobbleSword/NachoSpigot/commit/1bd45b3912e2251e0a848e70c1b9a6b093a4bf25

jamoeight commented 2 years ago

Ill try that and let you know!

ghost commented 2 years ago

Most likely caused when unloading chunks

crafter23456 commented 2 years ago

https://github.com/crafter23456/NachoSpigot/actions/runs/2101966227 prob that but intellij says still NoSuchElementException if the iteration has no more elements. have not the time yet but it might work

jamoeight commented 2 years ago

Ill try it out.

crafter23456 commented 2 years ago

Ill try it out.

did it worked?

Koboo commented 2 years ago

@EzJamo which plugins do you use? It seems that this is an error generated by a plugin, see answer in: https://github.com/PaperMC/Paper/issues/6758#issuecomment-992115320

I also found a spigot jira ticket for this, however there appears to be no activity at all. https://hub.spigotmc.org/jira/browse/SPIGOT-6793

Or does NachoSpigot execute something asynchronously here, creating concurrent modification itself?

ghost commented 2 years ago

@EzJamo which plugins do you use? It seems that this is an error generated by a plugin, see answer in: PaperMC/Paper#6758 (comment)

In that case, it’s most likely due to Nacho using a newer version of fastutil that is messed up by plugins because the author specifies that it didn’t happen on TacoSpigot