search

Cobenian / raygun

A raygun client for Elixir
Apache License 2.0
19 stars 15 forks source link

Timex dependency #24

Closed smdern closed 8 years ago

smdern commented 8 years ago

Elixir 1.3 added Calendar structs which Timex 3.0+ takes advantage of. Is there any plan on releasing a new semver that uses ~> timex 3.0 ?

smdern commented 8 years ago

Looks like timex is used in a single place, which means it could be removed as a dependency all together.

https://github.com/Cobenian/raygun/blob/f5f9596f9c610a7b6f95d847dd4920f2bb0ee9c7/lib/raygun/format.ex#L138

could be converted to just DateTime.utc_now |> DateTime.to_iso8601

smdern commented 8 years ago

https://github.com/Cobenian/raygun/pull/25

brweber2 commented 8 years ago

Merged the pull request. Closing.