search

Cobenian / raygun

A raygun client for Elixir
Apache License 2.0
19 stars 15 forks source link

Version number reported to raygun in the package version #7

Closed RobinClowers closed 8 years ago

RobinClowers commented 8 years ago

When are reported from our elixir app, the version number is the raygun package version, not our application's version.

brweber2 commented 8 years ago

This one is a bit more tricky. This project is a library so it doesn't have access to the configuration of the actual project that includes this library and we can't really make any assumptions about the project (even that it is a mix project). We could potentially open this up and allow the version to be passed in (via the plug config for example...). What do you think about that as a proposed solution? Would that work for you?

RobinClowers commented 8 years ago

Yeah, I think specifying it via the plug config would be fine.

brweber2 commented 8 years ago

Before I make any code changes, have you tried adding this to your project's config (obviously with your name/version):

config :raygun,
    client_name: "MyApp",
    client_version: "2.3.4"
brweber2 commented 8 years ago

It looks like the "version" and "client.version" are transposed in the format.ex.... I'm going to give this a little thought to see if there is something better I can do for handling application and library info.

RobinClowers commented 8 years ago

No, it seems we overlooked the bit in the readme about being able to specify the version. It would be great if it could be automatic though.

brweber2 commented 8 years ago

OK, I've switched the two version values around. Released as 0.1.5. I'm going to leave this issue open for a little bit as I re-think my approach, but hopefully your particular issue is addressed in 0.1.5.

RobinClowers commented 8 years ago

Great, I'll test it out tomorrow and let you know.

brweber2 commented 8 years ago

OK, I think I figured it out. If you use Raygun.Plug it will auto-detect the app's version for you. This was released in 0.1.6.

aaronjensen commented 8 years ago

Speaking for @RobinClowers, who is on my team, I can confirm that we are seeing version numbers now, so this can be closed out, I think.