search

Cobertos / md2notion

A better Notion.so Markdown importer
MIT License
654 stars 65 forks source link

feat(images): upload images in the html blocks #21

Closed wongsingfo closed 3 years ago

wongsingfo commented 3 years ago

Motivation: Many markdown editors (e.g., typora, ...) use HTML to insert images so that we can set the image size easily. However, HTML in md2notion is preserved, that is, it do nothing with the images in the HTML blocks.

This PR is aims at uploading images that are mentioned in HTML blocks.

Cobertos commented 3 years ago

Definitely seems interesting. I'm open to converting tags considering ![]() tags are not necessarily the best vehicle for getting images into Notion through markdown, from experience

Cobertos commented 3 years ago

Oh, and a test would be nice too ;-;

Cobertos commented 3 years ago

Lgtm, I might make a few docs changes but Ill merge and release a new version by the end of next week.

Cobertos commented 3 years ago

All merged, just had one fix

https://github.com/Cobertos/md2notion/commit/d52dde99cd396e09459b123fb96e6c8aa2bb418d

(wasn't sure how to push it to the PR as I was denied permission to push to the fork, gotta figure out how to do that sometime in the future)

Cobertos commented 3 years ago

Oh, and thank you for the contribution :3. I forgot to mention x3