search

Cobinja / CobiAnalogClock

GNU General Public License v2.0
1 stars 3 forks source link

New themes #7

Closed jorgenqv closed 8 years ago

jorgenqv commented 9 years ago

Hello, I made two themes from some CC licensed SVG graphics I found at http://www.3quarks.com/en/SVGClock/ and on http://commons.wikimedia.org/wiki/File:Station_Clock.svg Hope I made the themes correct and I did everything correct here at Github, this is my first new file pull request ever :-) /Jörgen

Cobinja commented 8 years ago

While the WallClock theme is perfectly fine, I think the Railway one deserves a little less space between the image and the border.

jorgenqv commented 8 years ago

Thank you Lars, and yes I totally agree. The reason the Railway one is smaller is that the clock pointers for this theme needs to be stretch out longer on the clock face, also the wall one would need slightly longer ones. But I have no idea how that could be done, not affecting the look of the other themes. Or perhaps larger default clock pointers is alight?

Cobinja commented 8 years ago

You could decrease the overall width and height of the images, leaving the content at the same size. Then adjust the size entry in metadata.json accordingly.

jorgenqv commented 8 years ago

Ahh, I didn't get how that works, tried to change the values in metadata.json but only got the clock face up in the left corner. But I will give it a go again! :) Will get back to you, thanks!

Cobinja commented 8 years ago

I use the size value to determine the scaling factor between the svg images and the displayed desklet size.

jorgenqv commented 8 years ago

Did some work on the themes and now I know how it works :) Also added icon.png used by Cinnamon Desklet Manager and a short hints text about working with themes in the readme. I have some trouble uploading the icon.png in the right directory here at Github...

Cobinja commented 8 years ago

Looks fine now. Except for the location of icon.png, you missed the ".de" in the folder name.

jorgenqv commented 8 years ago

Thank you for taking time to look at my theme work. I can not upload the png file there, if I enter the directory "analog-clock@cobinja.de" and click on Upload file the last ".de" part is cut of and a new directory is created, strange...

Cobinja commented 8 years ago

To be honest, I don't really like the BigBen theme, especially the background. Looks as if it's the scan of the cutout of a photo. About icon.png: Just do it locally on your machine, do the commit and push the branch. Works perfectly well.

jorgenqv commented 8 years ago

Yeah, you’re right, it is perhaps a bit too much to have on your desktop and is actually a CC image from Wikimedia Commons, it also got a bit dull in the colours when converted to SVG. Thanks for your honesty! :) Will try to set up git on my local machine.

jorgenqv commented 8 years ago

Done, worked fine as you suggested.

muzena commented 8 years ago

@Cobinja Can you upload to spicies page version with new themes.

Cobinja commented 8 years ago

I will include them in the new version I am currently preparing