Add option: close all windows w/ middle mouse button

Cobinja / CobiWindowList

A window list applet for Cinnamon

GNU General Public License v2.0

16 stars 4 forks source link

Add option: close all windows w/ middle mouse button #28

Closed robsdedude closed 4 years ago

robsdedude commented 4 years ago

If the new option is enabled, middle mouse button click (i.e. mouse wheel click) on icon (not window preview) will close all windows in the group. To open a new window (middle mouse button by default) use shift + left mouse button instead (the latter is the default binding in Windows 7 btw.).

Closes #24

Cobinja commented 4 years ago

First of all: Thanks for the contribution.

This will not get merged as is, because

The version in the 4.0 folder is missing the new beahvior for left click
The setting should rather be a combobox offering both the current and the new behavior, defaulting to the current one. This will make it easier to add other behaviors without breaking the settings UI.

If both points are resolved, I'll take another look.

robsdedude commented 4 years ago

Oops. I overlooked the first thing.

About the combobox: what do you imagine the options to look like? Describing all bindings in a few words will be tough. As you can see I currently use a tooltip to unclutter the UI. One could try to add a combobox for basically every button to allow full customization of all bindings but this seems overkill. So I don't think that stuffing it all into a combobox is a good idea.

Cobinja commented 4 years ago

The combobox items could be e.g. "Open new window" and "Close all windows", and then more descriptive tooltip on the combobox itself. See the other settings as an example. For some settings, a combobox does make sense, for others, it does not. This is one where it does.

robsdedude commented 4 years ago

Here you go.

robsdedude commented 4 years ago

Hi, what's the state of this PR? Any other changes to discuss or improve?

Cobinja commented 4 years ago

There are a couple of reasons for me not to merge this:

I didn't really like the idea of this setting in the first place
The 3.2 folder is kind of discontinued. I only left it in for legacy support. New features will definitely only go into the newest version folder, which is 4.0 at this moment
The way this setting is realized is not what I had in mind when considering this PR. I think it's not a good idea to merge two settings into one, which is the case with your second option in the combobox. This kind of setting would require 3 more settings, which I want to keep simple
Middle click in Windows 7 and 10 also opens a new window, which is why I implemented it the way I did

robsdedude commented 4 years ago

If I had known earlier, I could've stopped wasting my time =(
Too bad for me, as I'm still running Mint 18, and as far as I know, it still uses 3.2
That's what I meant by saying

One could try to add a combobox for basically every button to allow full customization of all bindings but this seems overkill. So I don't think that stuffing it all into a combobox is a good idea.

I think, however, it would've only needed two comboboxes (i.e. action on middle click and action on shift+left click)
Ok. But windows isn't the gold standard and other programs under Mint (e.g. the default window list and chromium) close tabs with middle click.

Anyway, thanks for your work.

Mgldvd commented 4 years ago

I think there is no harm to add this function like @robsdedude says is the default windows list behavior . I stopped using this app like 1 year ago just for this middle click thing, but i missed a lot, is a good app. For now I'm going to try for some time @robsdedude branch cuz is working in Linux Mint 19.3. Thank both :)