Cobresun / movie-club

🍿 Movie Club Website!
https://cobresun-movie-club.netlify.app
0 stars 1 forks source link

Add support for edit and delete reviews #175

Closed cole-adams closed 3 months ago

cole-adams commented 4 months ago

Changes:

brian-norman commented 4 months ago

Test failed 😅

brian-norman commented 4 months ago

I get this error when trying to run locally:

✘ [ERROR] [plugin dynamic-imports] Private name #props is not defined. (2:47)

    node_modules/kysely/dist/esm/index.js:85:14:
      85 │ export * from './migration/file-migration-provider.js';
         ╵               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onDynamicImport" callback registered here

    ../../.nvm/versions/node/v19.9.0/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/lib/main.js:853:22:
      853 │         let promise = setup({
          ╵                       ^
cole-adams commented 4 months ago

I get this error when trying to run locally:

✘ [ERROR] [plugin dynamic-imports] Private name #props is not defined. (2:47)

    node_modules/kysely/dist/esm/index.js:85:14:
      85 │ export * from './migration/file-migration-provider.js';
         ╵               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onDynamicImport" callback registered here

    ../../.nvm/versions/node/v19.9.0/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/lib/main.js:853:22:
      853 │         let promise = setup({
          ╵                       ^

Hmm, I got the test passing but I'm not sure about your error. The deploy worked. Maybe try updating your netlify cli?

brian-norman commented 3 months ago

Bug: I add a new review on the Reviews Page, click into the edit score field, and it's always pre-populating that field with the score of the movie we saw most recently. If I click down to edit any other movie now, it pre-populates the score with the score of the movie at the previous index. Smells like a classic off by one error after all the indexes are invalidated when we add a new movie 😛

brian-norman commented 3 months ago

Bug: If I add a new movie on the Reviews Page, I am unable to switch between gallery view and table view. I'm also unable to sort the movie scores in this state

Also, it seems that if I add a new movie on the gallery view, it doesn't show up in the gallery!

cole-adams commented 3 months ago

Issues found should be working now