Closed Cobular closed 3 years ago
I have a few ideas, thought I would get them down.
Nothing is being done now (other than the automatic code review thing I set up see #8 ).
Unfortunately I think the only real way to test this framework is with application testing via a test suite designed to test every function in the interface. Our example modules can serve this purpose nicely, I think.
That's true. You suggest running the two example bots as a test? I can setup something on some CI/CD service that just does that every commit. I did a code coverage test, and with CLI we hit 71% (IIRC) of the code. If we also launch in interactive, even if we don't do any tests and just let startup happen, that should be almost all the code being run and should catch just about anything wrong.
perfect. two birds, one stone.
On Mon, May 27, 2019, 11:30 AM J Cover notifications@github.com wrote:
That's true. You suggest running the two example bots as a test? I can setup something on some CI/CD service that just does that every commit. I did a code coverage test, and with CLI we hit 71% (IIRC) of the code. If we also launch in interactive, even if we don't do any tests and just let startup happen, that should be almost all the code being run and should catch just about anything wrong.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JakeCover/distest/issues/10?email_source=notifications&email_token=AK6KUYN5GJ24J52SUGWUAVTPXQEBZA5CNFSM4HPMNYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKFRMI#issuecomment-496261297, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6KUYLBS4UQNCAKBCNJXZDPXQEBZANCNFSM4HPMNYUQ .
Ok this works now? I'm going to leave this open for a little while tho in case things aren't going as planned
Actually I might want to try to run the tests with some code coverage on them, which I will do soonly (tm)
It's all working right now!
This is a huge ask, but it needs to be done at some point so it gets an issue! When I start working on this (eventually...), I will make a new feature branch (or a new repo - IDK how this will end up working)