search

Cobular / distest

A library used to do integration testing on discord bots
MIT License
29 stars 8 forks source link

Suggestion: Remove all "running test $TEST" statements #13

Closed JosephFKnight closed 5 years ago

JosephFKnight commented 5 years ago

the discord.py library gives us sane rate handling, blessed be to Danny. So this means that if a bot is spamming the library holds onto its messages so it doesn't get denied by discord. Therefore every message we send that isn't a test during a --run all reduces test throughput.

the "running test.." messages cut our test throughput in half, doubling the amount of time it takes to run a full suite.

I propose we hotfix this in, it would take the removal of only a couple lines.

JosephFKnight commented 5 years ago

I opened a pr #14 that pushes this to master branch. But you can just use that as a blueprint and remove those four lines in whatever branch you think is appropriate.

Cobular commented 5 years ago

That sounds great, I hadn't thought of that. I'll take a look!

JosephFKnight commented 5 years ago

I'm gonna just go ahead integrate this change in feature/refactor_modules and it will get added in when we push to master, as I imagine we aren't far from the next release.