search

Cobular / distest

A library used to do integration testing on discord bots
MIT License
29 stars 8 forks source link

Suggestion: Refactor __init__.py into separate modules #3

Closed JosephFKnight closed 5 years ago

JosephFKnight commented 5 years ago

I believe most if not all of the classes in __init__.py should be in their own files to make the code easier to work with. I would be willing to take on this refactor but obviously won't without a greenlight from @JakeCover

Cobular commented 5 years ago

For sure, if you can do it and still make the package work. I know it's possible, but I don't have enough experience myself. If you can do it, go ahead!

JosephFKnight commented 5 years ago

sure thing i'll set to working on it this weekend.

Cobular commented 5 years ago

Ok, the Refactor is done as of #5 being committed. Great job!

Cobular commented 5 years ago

With your agreement, I'll close this issue

Cobular commented 5 years ago

Actually, can you write a blurb about how the new code structure works, and what now lives in each file? This would be really useful to make sure we know what to add to each file. IMO a docstring at the top of each new file should work great, just a short paragraph is fine.

JosephFKnight commented 5 years ago

Sure I can bang that out right now.

JosephFKnight commented 5 years ago

Closing this since the refactor is complete and pushed to master.