Closed Cobular closed 5 years ago
Since all of the assert_reply_x
functions use their complementary assert_message_x
function, I think that using reply
counts as testing message.
Does that make sense? I also can think of no clever way to test these functions within the example modules.
You could write a test function that calls send_message()
and assert_message_x()
and basically build our own assert_reply_x()
for testing. They exist basically because they can (we need them anyway, so let's expose them) and because it lets you do custom things if you need. We really don't need to test the message assertions, like you said they are covered by the reply assertions, but we might want to just have them as examples and leave them commented out or something. I need to check, but the waits should also be covered.
Also question: can u check my checkboxes?
I just tested and yes, I can edit your checkboxes.
On Mon, May 27, 2019, 6:47 PM J Cover notifications@github.com wrote:
You could write a test function that calls send_message() and assert_message_x() and basically build our own assert_reply_x() for testing. They exist basically because they can (we need them anyway, so let's expose them) and because it lets you do custom things if you need. We really don't need to test the message assertions, like you said they are covered by the reply assertions, but we might want to just have them as examples and leave them commented out or something. I need to check, but the waits should also be covered.
Also question: can u check my checkboxes?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JakeCover/distest/issues/6?email_source=notifications&email_token=AK6KUYOQ5C6FOR4C3KALETTPXRXHNA5CNFSM4HPL7MDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKUKTI#issuecomment-496321869, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6KUYPJH22JWM7KFNHL4YLPXRXHNANCNFSM4HPL7MDA .
Updated the checklist to match what my coverage test told me was being run/not run. I'll hold off on this until #19 is done though, since that may change the way the interface functions are actually called.
Ok I think this is done as of the latest commit to #20. I'll close this when I close that shortly.