Cockatrice / Cockatrice

A cross-platform virtual tabletop for multiplayer card games
https://cockatrice.github.io
GNU General Public License v2.0
1.53k stars 447 forks source link

sets selection: group sets by type #133

Closed aeosynth closed 6 years ago

aeosynth commented 10 years ago

http://mtgjson.com/#sets

Each individual set is a JSON object like this:

// Type of set. One of: "core", "expansion", "reprint", "box", "un",
//                      "from the vault", "premium deck", "duel deck",
//                      "starter", "commander", "planechase", "archenemy",
//                      "promo", "vanguard", "masters"

this could be reduced to core, expansion, other

Daenyth commented 10 years ago

Great idea.

Varjo1 commented 10 years ago

Since each object includes releaseDate, we could also allow ascending and descending chronological sorting.

aeosynth commented 10 years ago

there are a number of ways to group / sort; on drafts.in, i use type + release date

Cerxi commented 10 years ago

Given that promo sets now have a unique prefix (A lowercase p), would you consider adding an option to sort those (as well as, perhaps, the Vanguard eternal set) to the top or bottom separately, in addition to chronological sorting?

tooomm commented 6 years ago

@Cerxi are you requesting to have a separate column for info like Game that one could sort for in Edit sets...?

Cerxi commented 6 years ago

No, when I posted this you couldn't just click "Set type" or "Release date" or whatever to sort ascending/descending, you had to drag sets into order one by one. The "Edit sets" dialogue has improved drastically in the intervening four years.

Daenyth commented 6 years ago

four years.

Thanks for sticking with us! :p

tooomm commented 6 years ago

What's this issue about then actually? 😄 I'm not sure if it's still relevant? It's also just referencing mtgjson...

Does anybody recall?

Cerxi commented 6 years ago

Thanks

Well, it's a good program!

What's this issue about

It was about adding properties beyond just names to Edit Sets, and automating sorting, both of which happened, so no, it's not really relevant anymore

tooomm commented 6 years ago

Thanks @Cerxi Feel free to let us know about any other issues or improvements.

For more years to come, hehe.