Cockatrice / Cockatrice

A cross-platform virtual tabletop for multiplayer card games
https://cockatrice.github.io
GNU General Public License v2.0
1.54k stars 449 forks source link

Name, save, and reload filter settings #4955

Open MotherofRuins opened 10 months ago

MotherofRuins commented 10 months ago

Would really like to be able to name, save, and later reload complicated filter settings to and from files. Would like to be able to edit those files with text editors. If people could copy and paste filter to clipboard, they could post the xml in http://www.reddit.com/r/Cockatrice and share and maintain popular filters such as for formats like Modern or Commander, including banlists.

If you implement a Scryfall type filter, I would still really like this ability.

ebbit1q commented 10 months ago

I'm not sure what you mean, you can use the search syntax in the search bar and copy and paste it, it accepts syntax similar to scryfall. the filter widget is separate and can't be saved, the scryfall search syntax was implented also because it addresses that

ebbit1q commented 10 months ago

is this a duplicate of https://github.com/Cockatrice/Cockatrice/issues/722 ?

MotherofRuins commented 10 months ago

It does seem to be a duplicate. Did not know we can do Scryfall searches in the search bar. In this case, though, a dialog similar to Scryfall's Advanced search page would be desirable. There is where I'd ask to be able to name, save, and reload complicated searches. Keeping a text file of old searches will be cumbersome.

tooomm commented 9 months ago

What about a history of past searches to select from a drop down in the search bar? That could be already a big help.

There could maybe be an option to pin ("save") specific searches if it should be more sophisticated.

MotherofRuins commented 9 months ago

Definitely prefer pinning if not both because some searches are quite complicated but get reused a lot. Or there is a base set of requirements (eg, not type contraption and not type plane etc) upon which different further searches occur for color, type, oracle, etc.

tooomm commented 9 months ago

there is a base set of requirements (eg, not type contraption and not type plane etc) upon which different further searches occur for color, type, oracle, etc.

Searches could be altered and added to after selecting the pinned base criteria.


I'm suggesting this as a simpler solution with good benefits to start with.

A new dialog with full search management could be a bit much. Especially as we still have the filter stuff around that is partially superseded with the "scryfall like" search already. Maybe that could be tweaked/replaced towards a search management pane with history and reuse/save. A good search doesn't need to filter down first.

Currently, we have 3 layers that influence the shown cards:

Back then people selected a pool of sets, chose some basic criteria in the filter and could only search for card names on top of the list. Now the search is way more powerful and can do both (filtering + search for names) in one. Plus that people are used to that from other places.