Cockpit-HQ / Cockpit

Cockpit Core - Content Platform
https://getcockpit.com
Other
363 stars 44 forks source link

Page cover up bug on load asset #197

Closed oelbaga closed 1 month ago

oelbaga commented 2 months ago

I often get this bug on the latest cockpit version. The page goes blurry and blank whenever I click anything to start adding an asset. It blocks the page and I have to refresh the page to get it working again and then I lose all my data entries. It seems to happen often on first load. I can’t identify what triggers it, it happens all the time on random clicks to add an asset.

image

image

aheinze commented 2 months ago

Do you get any errors in the js console which you can share? Also can you try to clear your browser cache?

oelbaga commented 1 month ago

Yes I found the console log errors here. This happens randomly when clicking to add an asset:

Screenshot 2024-07-23 at 10 55 01 AM
BimaBizz commented 1 month ago

Do you get any errors in the js console which you can share? Also can you try to clear your browser cache?

hey aheinze i do get same error, but after i downgrade it's work again

aheinze commented 1 month ago

which browser are you using?

BimaBizz commented 1 month ago

i use google chrome and share hosting

oelbaga commented 1 month ago

It happens on all browsers. I tested.

aheinze commented 1 month ago

Can you try the latest dev release? Thanks!

oelbaga commented 1 month ago

I don't want to use something that isn't ready for production yet but if this eventually gets released with the fix I would love to know!

Yohan-U commented 1 month ago

Hello, We are facing the same issue here, but in an other use case. When we add a component, we correctly get the components panel.

components_ok

Then close the component panel, go on an other browser tab or reduce the current browser window. Finaly try to add a component again, the components panel show nothing.

components_ko

The console logs look pretty similar to what was shared before. Our assumption is that the bug is related to the way the browser local storage is managed. It seems that the local storage is cleared because of the manipulations of the browser, and then the bug appears.

Interesting workaround in our case : if you use the "copy a component" feature first, you can't reproduce the pattern then. As if filling the local storage by yourself is fixing the bug.

This bug appeared in the version 2.8.5 (on which I reproduced this pattern). And developers on my team think that the file "addons/Layout/assets/vue-components/layout/component-picker.js", changed on the 2.8.5 version, could be a good place to take a look.

This bug makes the work of our Cockpit users actually really painful in a day to day use. I hope it will help to find a fix. And will be happy to share more details if needed. Thanks!

aheinze commented 1 month ago

@Yohan-U Is there a chance that you can try the latest dev release and verify that the issue is fixed? Thanks!

aheinze commented 1 month ago

v2.9.0 was just released which should come with a fix

oelbaga commented 1 month ago

Where can you check the cockpit version in the files?

aheinze commented 1 month ago

settings > system info

Yohan-U commented 1 month ago

v2.9.0 was just released which should come with a fix

@aheinze Great! We didn't have time to test the dev release yet. But we will check the v2.9.0 then. Thank you for the update.

oelbaga commented 1 month ago

settings > system info

Thank you, but I mean in the downloaded files of the repo itself. Where does it show the version in the code base?

Yohan-U commented 1 month ago

v2.9.0 was just released which should come with a fix

@aheinze After an upgrade to the version 2.9.0, I confirm the bug is gone for us. Thanks a lot!