search

CocoCR300 / flauncher

Fork of https://gitlab.com/flauncher/flauncher
GNU General Public License v3.0
14 stars 1 forks source link

New Feature: silent click #16

Open tpdi opened 2 months ago

tpdi commented 2 months ago

Flauncher currently emits a key pressed sound whenever a key on the remote is pressed.

This PR adds a user-configurable option to settings, to turn the sound off.

Also updates the sdk: ">=3.0.0 <=3.3.4"

CocoCR300 commented 2 months ago

The silent click only works for the directional buttons, using the center or "OK" button still emits a sound. If that's intended, I could merge this right away, or you can try to work that out. The other changes look fine, if you can replace the other button acting as a "switch tile" with an instance of the new class you added, that would be good.

tpdi commented 2 months ago

The silent click only works for the directional buttons, using the center or "OK" button still emits a sound. If that's intended, I could merge this right away, or you can try to work that out.

I completely missed this until you mentioned it. So it wasn't intentional, but I think I like having a sound on select, as there isn't any other feedback. Possibly we want a three-state, {no sound, select sound only, all keys}?

CocoCR300 commented 2 months ago

I like that idea, if you want to add that feature here, go ahead. But I'm also thinking about physical keyboards, I wonder if the keys on those also cause a sound to play, and if one can control that through the system settings.