search

CocoaPods / Core

The models used within the CocoaPods gem
MIT License
160 stars 349 forks source link

Fix warnings in `dependency.rb` #720

Closed ncooke3 closed 2 years ago

ncooke3 commented 2 years ago

dependency.rb has a few warnings that are showing up locally and in CI when pod lib linting.

For example, see https://github.com/firebase/firebase-ios-sdk/runs/5619185788?check_suite_focus=true.

  1. warning: method redefined; discarding old ... 
    /usr/local/lib/ruby/gems/2.7.0/gems/cocoapods-core-1.11.2/lib/cocoapods-core/dependency.rb:117: warning: method redefined; discarding old specific_version=
  2. warning: instance variable ... not initialized 
    
/usr/local/lib/ruby/gems/2.7.0/gems/cocoapods-core-1.11.2/lib/cocoapods-core/dependency.rb:112: warning: instance variable @specific_requirement not initialized

/usr/local/lib/ruby/gems/2.7.0/gems/cocoapods-core-1.11.2/lib/cocoapods-core/dependency.rb:133: warning: instance variable @external_source not initialized



cc: @paulb777
dnkoutso commented 2 years ago

The CI issue we have not yet identified. Its for Ruby 3.0, going to merge this for now. Thank you!