search

CocoaPods / Core

The models used within the CocoaPods gem
MIT License
158 stars 346 forks source link

Allow configuring CDN requests max concurrency to reduce flakiness #773

Closed maikelvdh closed 2 weeks ago

maikelvdh commented 1 month ago

Introducing COCOAPODS_CDN_MAX_CONCURRENCY configuration point to reduce the maximum concurrency of Hydra. The default max concurrency (200) can lead to flakiness like DNS resolution failure being marked as DoS attack OR missing authorization headers. This flakiness is also remarked in the documentation of typhoeus library.

maikelvdh commented 1 month ago

@santam85 FYI you might encounter similar issue depending on your setup when using Artifactory CDN if your local repository is containing large amount of indexed specs.

maikelvdh commented 1 month ago

@segiddins thanks for reviewing, added the changelog entry accordingly.

maikelvdh commented 1 month ago

@amorde sorry for tagging, but I noticed you were recently supporting merging PRs. would you mind to please take care of this one as well? thanks in advance!

maikelvdh commented 1 month ago

@amorde would you mind to recheck it again and merge it? thanks!

maikelvdh commented 3 weeks ago

@amorde sorry for asking again, but would you mind to recheck it and merge it? thanks a lot!

maikelvdh commented 2 weeks ago

@segiddins would you mind to merge this PR as well? thanks!

maikelvdh commented 2 weeks ago

Thanks @segiddins ❤️ ! Do you know by chance if there is a plan to produce a new release as well soon?