search

CocoaPods / Rome

Makes it easy to build a list of frameworks.
MIT License
696 stars 64 forks source link

Subspecs cleanup #13

Closed keith closed 9 years ago

keith commented 9 years ago

This covers some of the same stuff as https://github.com/neonichu/Rome/pull/11/ but I've also extracted some of the constants that were used multiple times. There's still 1 issue with this that it doesn't work correctly with dependencies (like Fabric/Crashlytics) that are precompiled binaries.

On the subspecs front I believe we also need the uniq I have in this script for specs that have a default subspec (my test has been APAddressBook)

segiddins commented 9 years ago

@keith we can probably address framework-only pods by directly copying any vendored frameworks over direct

keith commented 9 years ago

@segiddins awesome yea, I haven't gotten that far just yet but figured we should combine forces

segiddins commented 9 years ago

maybe @neonichu would be kind enough to give us push access? might make sense to start writing specs for this.

neonichu commented 9 years ago

@segiddins @keith sure, I'll add you

segiddins commented 9 years ago

:heart:

neonichu commented 9 years ago

keith commented 9 years ago

@neonichu @segiddins anything I should update before merging this?

segiddins commented 9 years ago

Seems fine to me

neonichu commented 9 years ago

:+1: