CocoaPods / Rome

Makes it easy to build a list of frameworks.
MIT License
694 stars 64 forks source link

It is necessary to specify the platform in the Podfile if not integrating. #40

Open jcampbell05 opened 8 years ago

jcampbell05 commented 8 years ago

It is necessary to specify the platform in the Podfile if not integrating.

use_frameworks!

plugin 'cocoapods-acknowledgements'
plugin 'cocoapods-rome'

abstract_target 'SupCore' do

  #Functional
  pod 'RxBlocking', '~> 2.1.0'
  pod 'RxCocoa', '~> 2.1.0'
  pod 'RxSwift', '~> 2.1.0'
  pod 'RxOptional', '~> 1.0.0'

  target 'Sup-Watch Extension' do
    platform :watchos, '2.0'

    #Mapping
    pod 'ObjectMapper'
  end

  target 'Sup' do
    platform :ios, '8.0'

    #UI
    pod 'KVNProgress'
    pod 'SWTableViewCell', '~> 0.3.7'
    pod 'TTTAttributedLabel'
    pod 'SwipeView'
    pod 'UICountingLabel'
    pod 'CPDAcknowledgements'
    pod 'UIImageViewWithWords'

    #Core
    pod 'IAmUpload'
    pod 'Crashlytics', '3.3.4'
    pod 'Branch'
    pod 'Fabric'
    pod 'Firebase', '~> 2.5.1'
    pod 'FBSDKCoreKit'
    pod 'FBSDKLoginKit'
    pod 'FBSDKShareKit'
    pod 'GoogleMaps'
    #pod 'GeoFire', :git => 'https://github.com/jcampbell05/geofire-objc.git', :branch => 'master'
    pod 'JLRoutes'
    pod 'JTSImageViewController'
    pod 'JSQMessagesViewController'
    pod 'SDWebImage', :git => 'https://github.com/roger-tan/SDWebImage.git', :branch => 'master'
    pod 'StatefulViewController', '~> 1.0'
    pod 'Parse'
    pod 'DateTools'
    pod 'Dwifft'
    pod 'NSOperationStack', :git => 'https://github.com/jcampbell05/NSOperationStack.git', :branch => 'master'
    pod 'Digits'
    pod 'libPhoneNumber-iOS', '~> 0.8'
    pod 'Moya'

    #Analytics
    pod 'Buglife'
    pod 'le'
    pod 'ARAnalytics', :subspecs => ["Mixpanel"]
    pod 'Google/Analytics', '~> 1.0.0'
    pod 'GoogleTagManager'
    pod 'Tweaks'
    pod 'Smooch'

    #Functional
    pod 'RxViewModel'

    #Misc
    pod 'Polly', '~> 0.2'

    target 'SupTests' do
      inherit! :search_paths

      #Screenshot Testing
      pod 'FBSnapshotTestCase'
    end
  end
end

When using 1.0, with the abstract targets this shouldn't be needed, it should build it correctly across platforms for multiple targets.

Related to #37

neonichu commented 8 years ago

I don't think using Rome should change the semantics of the Podfile. The same one should work with and without Rome.

jcampbell05 commented 8 years ago

@neonichu I'll run this again but it appeared to work without Rome on 1.0.

neonichu commented 8 years ago

It'll work with integration, because the platform is inferred from the Xcode project. But without project integration it shouldn't work, regardless of Rome usage.

It might be a thing to consider to make this work within CP generally, as you're specifying platforms for all concrete targets.