search

CocoaPods / Rome

Makes it easy to build a list of frameworks.
MIT License
694 stars 64 forks source link

Fix issue when uploading built frameworks to ITC. #46

Closed mjholgate closed 8 years ago

mjholgate commented 8 years ago

Because the order in which the frameworks were copied (simulator vs device) could vary, sometimes we ended up with the Info.plist used by the simulator, which upsets iTunesConnect with the following message:

[12:54:45]: ERROR ITMS-90542: "Invalid CFBundleSupportedPlatforms value. The key 'CFBundleSupportedPlatforms' in the Info.plist file in bundle 'Payload/Skyscanner.app/Frameworks/OAStackView.framework/OAStackView.bundle' contains an invalid value '[iPhoneSimulator]'. Consider removing the CFBundleSupportedPlatforms key from the Info.plist. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue."

Fix is to copy the simulator frameworks first, so the device Info.plist overwrites it.

mjholgate commented 8 years ago

@neonichu Not sure if this is the right fix or not (what should actually be in the Info.plist for a fat framework?), but it resolves the immediate issue for me at least!

neonichu commented 8 years ago

LGTM

mjholgate commented 8 years ago

Cheers @neonichu !