CocoaPods / Rome

Makes it easy to build a list of frameworks.
MIT License
694 stars 64 forks source link

Avoid using chdir since the behavior is unexpected now #48

Closed dulacp closed 7 years ago

dulacp commented 7 years ago

Well you know what the issue is. I hope my fix seems reasonable enough

Cheers

neonichu commented 7 years ago

Thanks for the PR, but I think using CP 1.1 rc1 already fixes this.

dulacp commented 7 years ago

Actually it's was still failing on my machine with CP 1.1.0.rc.1 (I saw your PR on the pthread chdir). That's why I did this PR.

I was getting this output in verbose mode :

Skipping User Project Integration
  - Running post install hooks
    - cocoapods-rome from
    `~/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/Rome-46feede9b90b/lib/cocoapods-rome/post_install.rb`
Building frameworks
      $ /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -project Pods.xcodeproj -scheme Pods-caesar -configuration Release
      -sdk iphoneos
      Build settings from command line:
          SDKROOT = iphoneos10.0

      xcodebuild: error: 'Pods.xcodeproj' does not exist.
[!] /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -project Pods.xcodeproj -scheme Pods-caesar -configuration Release -sdk iphoneos

Build settings from command line:
    SDKROOT = iphoneos10.0

xcodebuild: error: 'Pods.xcodeproj' does not exist.

ps: I also tried to use ruby 2.3.0, same error

drewcrawford commented 7 years ago

still an issue in cocoapods-1.1.0.rc.2

bestwnh commented 7 years ago

same issue in cocoapods-1.1.0.rc.2.

sanekgusev commented 7 years ago

The fix looks reasonable and trivial enough. Can it be merged? Together with https://github.com/CocoaPods/Rome/pull/46, would make a great v0.8.0. 🚢

karagraysen commented 7 years ago

👍 Please merge. I love Rome and can't use it.

segiddins commented 7 years ago

Thanks!

karagraysen commented 7 years ago

Yay, thanks @segiddins. 🎉 Will this automatically be update the Gem?

segiddins commented 7 years ago

@istx25 no, but I can take a look at doing a release later in the week