CocoaPods / Rome

Makes it easy to build a list of frameworks.
MIT License
694 stars 64 forks source link

Add dsym generation/export #56

Closed UnsafePointer closed 6 years ago

UnsafePointer commented 7 years ago

Cocoapods Rome is a great alternative for Carthage if you depend on libraries that don't support Carthage yet and you'd like to avoid the CocoaPods integration with the user project. The only thing missing is that you can't debug the third party frameworks properly because the dSYM information is deleted after build and it defaults to "Release" configuration which has compiler optimisations that affect the debugger (wrong stepping and missing variable).

This PR includes the following:

Lascorbe commented 7 years ago

Maybe you can add an opt-out parameter to do not link dSYM. I think there'll be way more people interested in having dSYM linked by default than the other way around. WDYT?

Thanks for the PR! 🍷

BasThomas commented 7 years ago

Are there any updates on this?

orta commented 6 years ago

OK, just looked this over, sorry for the year late review - but better than nothing.

There is a feature for cocoapods-plugins that allows passing options:

plugin 'cocoapods-rome',  {
  dsym: true,
  configuration: "Release"
}

maybe? ( you can see a usage example in https://github.com/CocoaPods/Rome/pull/61 )

This'll need docs, in the README - but conceptually I think it should get merged 👍

UnsafePointer commented 6 years ago

@orta thanks for the review! Agree, better than nothing 🎉

@Lascorbe @orta I included both of your comments, thank you.

orta commented 6 years ago

Cool, and I just merged another PR, so you have merge conflicts too ;)

UnsafePointer commented 6 years ago

@segiddins thanks for the review!

orta commented 6 years ago

Cool, yep, looks good to me