CocoaPods / Rome

Makes it easy to build a list of frameworks.
MIT License
694 stars 64 forks source link

Issues with adding firebase through rome #73

Open alokc83 opened 5 years ago

alokc83 commented 5 years ago
screen shot 2018-11-03 at 11 09 24 am

Getting these error when adding firebase through "Rome". Only difference that I see Rome doesn't create an umbrella framework called "Firebase" There is no issue if I add these frameworks as cocoapods, which is undesirable.

paulb777 commented 5 years ago

See https://github.com/firebase/firebase-ios-sdk/blob/master/Rome.md. Step 13 should set up the Firebase module.

alokc83 commented 5 years ago

@paulb777 : thanks a lot quick reply. I followed all the all the steps. It seems it doesn't have any effect. I have the same errors.

paulb777 commented 5 years ago

@alokc83 Based on googling that error message, it might be related to ./Rome/FirebaseCoreDiagnostics.framework/Modules/module.modulemap not having an umbrella header, but I'm not able to reproduce the error. What version of Xcode are you building with? Does adding an umbrella header to that modulemap file make a difference?

alokc83 commented 5 years ago

@paulb777 : I am using Xcode 10.1 and Cocoapods 1.5.2

paulb777 commented 5 years ago

@alokc83 I was wondering if the issue was related to Xcode 10.1, but I got that set up today and I'm still not able to reproduce. We'll likely need a reproducible example to make progress.

If you haven't tried already, try flushing the Xcode state - rm -rf ~/Library/Developer/Xcode/DerivedData etc.

DrewKiino commented 5 years ago

I was able to add Firebase with Rome through XCodegen as my project builder. but looking at the files I'm sure you should be able to add them in manually with the given configuration too

https://github.com/firebase/firebase-ios-sdk/issues/3432