CocoaPods / Rome

Makes it easy to build a list of frameworks.

MIT License

696 stars 64 forks source link

iOS frameworks should contain ARM slices #8

Closed robb closed 9 years ago

robb commented 9 years ago

When building a framework for iOS, for example AFNetworking:

platform :ios, '8.0'
use_frameworks!

plugin 'cocoapods-rome'

pod 'AFNetworking'

Rome should also build slices for ARM CPUs. Currently the resulting framework only contains i386 and x86_64 slices:

$ lipo -info Rome/AFNetworking.framework/AFNetworking
Architectures in the fat file: Rome/AFNetworking.framework/AFNetworking are: i386 x86_64

neonichu commented 9 years ago

Yep, that would make sense - this is basically what #1 is meant to do.

hwaxxer commented 9 years ago

I'm still seeing this issue with 0.2.0.

hwaxxer commented 9 years ago

25 fixes this issue.

Edit: but it also breaks some pods, I'll see if I can make it work.

hwaxxer commented 9 years ago

Looks like some frameworks (AFNetworking, Alamofire, DateTools) are placed outside of the Configuration-sdk folder.

neonichu commented 9 years ago

Ah, I see what the problem is now, target deduplication in newer versions of CP. Would probably make sense to just disable it for Rome. I'll look into it later today.

hwaxxer commented 9 years ago

Oh makes sense now. I couldn't figure out why they were disappearing. Thanks!