Manu force builddir use installed sandbox

manuyavuz commented 4 years ago

This PR provides a few improvements:

Rome was not working for local pods with vendored_library values set. Reason and fix:
- If we create a new sandbox object here, development_pods value would be nil because it's only saved when store_local_path methods is called. This makes file_accessor to fail when looking for vendored_libraries for local pods. Using sandbox in installer context fixes this issue.
Rome assumes that build products will exist under Pods/../build after build is completed, and it's default behavior of CP due to setting of SYMROOT as '${SRCROOT}/../build'. This breaks projects which provides a custom symroot during post_install.
- I decided to override build dir for xcodebuild as building for Rome should be kept separated from actual development lifecycle.

Ricowere commented 3 years ago

I can confirm this fix many of my issues when trying to copy resources, vendors and so on to the output_folder.

By creating a new Sandbox object, it makes cocoapods to look for incorrect paths for some local pods I had.

Before the fix; for a local pod in the folder ../api/API.podspec it was trying to look at an inexistent Pods/API path.
After the fix; for a local pod in the folder ../api/API.podspec it did successfully look at ../api/**/*path.

manuyavuz commented 3 years ago

I am going to go ahead and merge this. I have been using Rome with these changes for a very long time. And the changed are minimal.

CocoaPods / Rome