CocoaPods / blog.cocoapods.org

The blog for CocoaPods
https://blog.cocoapods.org/
34 stars 38 forks source link

[draft] Shallow clone post mortem. #129

Closed alloy closed 8 years ago

alloy commented 8 years ago

Closes #128.

/cc @CocoaPods/core

orta commented 8 years ago

đź‘Ť

alloy commented 8 years ago

Updated, thanks y'all!

Waiting to add a few more links to the changes that were made.

alloy commented 8 years ago

Just realised that I should probably also add a short section on how to convert a shallow clone to a full clone for those that are still on < 1.0.0.beta.6.

Are we using just git fetch --unshallow ?

orta commented 8 years ago

Yep - https://twitter.com/CocoaPods/status/707340665462636544

AliSoftware commented 8 years ago

Seeing that comment I realized I didn't execute it on my work Mac so I tried and here's the error I got:

$ cd /.cocoapods/repos/master
$ git fetch --unshallow
fatal: --unshallow on a complete repository does not make sense
orta commented 8 years ago

you might have:

AliSoftware commented 8 years ago

Aaaah maybe I already did it anyway indeed; makes sense now… the error was confusing me because I thought "a complete repo" in the sense of "the whole directory, unshallowing from the root of your working copy", not "a complete, already unshallowed copy" but now it's so obvious…

segiddins commented 8 years ago

Looks good @alloy <3

alloy commented 8 years ago

Ok everybody, I had to remove the numbered lists (as it breaks with multiple paragraphs) and nested lists because that didn’t work at all.

mrackwitz commented 8 years ago

:+1:

alloy commented 8 years ago

@mhagger @vmg @mikemcquaid @arthurnn Before posting this on our blog, I’d like to give you the chance to review for correctness from your point of view. I’d like to post this over the next few days.

mhagger commented 8 years ago

The draft looks correct regarding the things I know about the subject. Thanks for fixing these problems, and thanks for the writeup! :sparkles:

alloy commented 8 years ago

@mhagger Thanks for reviewing!

segiddins commented 8 years ago

:ship: ?

alloy commented 8 years ago

Ok, let’s do it.

arthurnn commented 8 years ago

:tada: