Settings bundle compatible plist not actually used

CocoaPods / cocoapods-acknowledgements

CocoaPods plugin that generates a plist which includes the installation metadata

MIT License

111 stars 17 forks source link

Settings bundle compatible plist not actually used #20

Closed masaniemi closed 8 years ago

masaniemi commented 8 years ago

It seems that even though I use the ":settings_bundle => true" setting, the plugin does not really use the metadata generated by SettingsPlistGenerator for anything. Instead, it simply copies the previously generated full podspec metadata list to settings.bundle dir.

marcelofabri commented 8 years ago

This is actually true :astonished:

Sorry for the delay. @masaniemi, can you check if https://github.com/CocoaPods/cocoapods-acknowledgements/pull/21 solves the issue?

masaniemi commented 8 years ago

Thanks for the fix! Unfortunately I had to go with a different solution for the acknowledgements listing, but this definitely seems like the correct fix to me.

marcelofabri commented 8 years ago

I'm closing this issue then. Please feel free to reopen or open another one if you find the fix wasn't enough. Thanks for reporting this!