search

CocoaPods / cocoapods-acknowledgements

CocoaPods plugin that generates a plist which includes the installation metadata
MIT License
111 stars 17 forks source link

xcproj not running #29

Closed ghost closed 8 years ago

ghost commented 8 years ago

Cocoapods is supposed to run xcproj to convert the .xcproj file to ASCII instead of XML. However when using

plugin 'cocoapods-acknowledgements', :settings_bundle => true

in the podfile, this does not happen and the .xcproj stays in xml form instead of converting back to ASCII form. This causes major merge issues and makes merging a headache.

segiddins commented 8 years ago

CocoaPods hasn't used xcproj for over a year.

ghost commented 8 years ago

How come the acknowledgements plugin then changes everything to xml instead of leaving it ASCII?

segiddins commented 8 years ago

I don't know -- can you share an example project that demonstrates the issue?

ghost commented 8 years ago

sure, give me a few days to get some downtime and create one.

BarakatX2 commented 8 years ago

I had the same issue. I've attached an example project. demo-plugin-bug.tar.gz

Steps:

tar -xf demo-plugin-bug.tar.gz
cd DemoPluginBug/
cat DemoPluginBug.xcodeproj/project.pbxproj # not xml
pod install
cat DemoPluginBug.xcodeproj/project.pbxproj # now xml

Xcode Version 7.3 (7D175) local-gems.txt

marcelofabri commented 8 years ago

@BarakatX2 there's an issue with xcodeproj 0.28.2, which CocoaPods 0.39 uses. Please update CocoaPods (and cocoapods-acknowledgements) to 1.0.0 to fix it.