search

CocoaPods / cocoapods-acknowledgements

CocoaPods plugin that generates a plist which includes the installation metadata
MIT License
111 stars 17 forks source link

Bug with settings_bundle setting #41

Closed winkelsdorf closed 5 years ago

winkelsdorf commented 7 years ago

Having the following code to explicitly exclude the acknowledgements from the settings.bundle (I am using the meta plist instead):

plugin 'cocoapods-acknowledgements',
    :settings_bundle => false,
    :exclude => [
        'SimulatorStatusMagic',
        'Reveal-SDK',
        'Quick',
        'Nimble'
    ]

Acknowledgements are still copied to the Settings.bundle.

In https://github.com/CocoaPods/cocoapods-acknowledgements/blob/master/lib/cocoapods_acknowledgements.rb#L54 settings_bundle is checked for nil, not for true.