CocoaPods / cocoapods-acknowledgements

CocoaPods plugin that generates a plist which includes the installation metadata
MIT License
111 stars 17 forks source link

Search project files for the Settings.bundle file #42

Closed jhildensperger closed 7 years ago

jhildensperger commented 7 years ago

I have my build directory in the same folder as my project and using Dir.glob("**/*Settings.bundle").first is matching the Settings.bundle file from a previous build.

This seems to fix the issue for my use case.

ssuchanowski commented 7 years ago

+1

orta commented 7 years ago

Yeah, that seems good to me, thanks for the +1, I missed this

@jhildensperger can you add a CHANGELOG entry please? Other that that, it's good to go 👍

leoformaggio commented 7 years ago

Wondering if this is good to merge, it might fix #32 too

orta commented 7 years ago

Ah yeah, sorry, didn't notice it was updated :D