search

CocoaPods / cocoapods-acknowledgements

CocoaPods plugin that generates a plist which includes the installation metadata
MIT License
111 stars 17 forks source link

Html rendering #47

Open lolgear opened 6 years ago

lolgear commented 6 years ago

Architecture changed.

  1. Base class Generator added.
  2. Module Auxiliaries added which contains file handling operations. Could be merged into base class Generator.
  3. HTMLGenerator added.
  4. Plist and HTML Writers added which handles output to appropriate file format.
lolgear commented 6 years ago

@segiddins updated. nokogiri dependency removed.

hamdshah commented 5 years ago

Any chance of merging this branch ?

orta commented 5 years ago

I don't think it's done, see: https://github.com/CocoaPods/cocoapods-acknowledgements/pull/47/files#diff-86a5d812fd9ecac367ea96aaa1964994R4

lolgear commented 5 years ago

@orta It is an obsoleted class. ( or duplicate ). I use PlistGenerator instead. They are identical in terms of Model. You can check invocations of HTMLGenerator. Maybe anybody can figure out what we can do with it in future. For now it is empty and it copies whole body of PlistGenerator. ( yeah, copy-paste is evil ).

Update: HTMLWriter consumes PlistGenerator::SpecObject to generate correct output.

lolgear commented 5 years ago

Weird, build error.

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.3)
  Current Bundler version:
    bundler (2.0.1)
lolgear commented 5 years ago

@segiddins Could you post a review?