search

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)
MIT License
84 stars 71 forks source link

supporting file type from sonatype nexus query urls #101

Closed guyyosan closed 3 years ago

guyyosan commented 4 years ago

sonatype nexus sometimes uses urls with query params.

attempt to fix: https://github.com/CocoaPods/cocoapods-downloader/issues/100

tested locally with sonatype nexus, it works

dnkoutso commented 4 years ago

Can you please add a test?

guyyosan commented 4 years ago

@dnkoutso I'm a novice ruby dev :) can you please refer me to this method's test: type_with_url?

guyyosan commented 4 years ago

@dnkoutso fixtures? ex. https://github.com/guyyosan/cocoapods-downloader/blob/master/spec/remote_file_spec.rb ?

dnkoutso commented 4 years ago

Yes add one in remote_file_spec.rb.

Run it as bundle exec bacon /path/to/remote_file_spec.rb

guyyosan commented 4 years ago

@dnkoutso it's working ok now. build is passing on 2/4 machines. the other 2 machines has issues with gem installations not related to my fix.

seanreinhardtapps commented 4 years ago

The failed tests are an issue with RVM with certain Ruby versions on Travis CI VMs. See #97

guyyosan commented 4 years ago

@seanreinhardtapps @dnkoutso is there a way to rerun ci now that https://github.com/CocoaPods/cocoapods-downloader/pull/97 is merged? I mean, without adding a new commit

amorde commented 4 years ago

LGTM with 1 minor change

guyyosan commented 3 years ago

@amorde updated

guyyosan commented 3 years ago

@amorde Hi Eric, last build is failing for one machine.. doesn't look code related:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
guyyosan commented 3 years ago

@dnkoutso can you please check this, I really need a proxy working asap and this is a blocker. The build is actually succeeds on all machines but 1 and I don't understand the error, it's like output is missing