search

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)
MIT License
84 stars 71 forks source link

Fix bug of Git shallow cloning is not used when branch is set #106 #111

Closed dimohamdy closed 3 years ago

dimohamdy commented 3 years ago

https://github.com/CocoaPods/cocoapods-downloader/issues/106

dimohamdy commented 3 years ago

@fabiopelosin Can you check this PR?

segiddins commented 3 years ago

Can you please add a test that covers behavior in this case? Thanks!

dimohamdy commented 3 years ago

@segiddins I will

dimohamdy commented 3 years ago

@segiddins I add a unit-test for it

dimohamdy commented 3 years ago

@segiddins Can you check the PR Please?

dimohamdy commented 3 years ago

@segiddins @fabiopelosin Any update or plan to merge this PR?

dnkoutso commented 3 years ago

@dimohamdy please rebase and squash into a single commit.

Add a changelog entry and make sure you rebased on latest master.

dimohamdy commented 3 years ago

@dnkoutso Please check the new PR https://github.com/CocoaPods/cocoapods-downloader/pull/117 and I will close this one