search

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)
MIT License
84 stars 71 forks source link

Fix bug of Git shallow cloning is not used when branch is set #117

Open dimohamdy opened 3 years ago

dimohamdy commented 3 years ago

Fix https://github.com/CocoaPods/cocoapods-downloader/issues/106

dimohamdy commented 3 years ago

@dnkoutso I cleaned the branch and update the changelog

xuzhongping commented 2 years ago

@dimohamdy Hi，I noticed the line of code you deleted:

# lib/cocoapods-downloader/git.rb
options.delete(:branch)

The relevant code comes from a PR #57 , which is used to deal with the cache problem of cocoapods(:git && :branch). If you delete this line of code, it may affect the pod (:git && :branch) cache detection of cocoapods. I don’t know if you have tested these scenarios.

uliluckas commented 2 years ago

Any chance, this gets merged?

ptrkstr commented 1 year ago

This would be useful to have 🙏