search

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)
MIT License
84 stars 71 forks source link

Switches where we check for invalid input, to move it inside the download function #127

Closed orta closed 2 years ago

orta commented 2 years ago

While CocoaPods would have seen this issue, moves the check into the core path of using the cocoapods-download api. We're supposed to assume clients would not always run the pre-process API:

      # preprocess download options
      #
      # Usage of this method is optional. concrete strategies should not
      # assume options are preprocessed for correct execution.
      #
dnkoutso commented 2 years ago

LGTM @orta want to do it for 1-6-stable so I can ship 1.6.3?

orta commented 2 years ago

Hrm, tests passed locally, let's see what's up

dnkoutso commented 2 years ago

I think it was just rubocop