Ensure that the git pre-processor doesn't accidentally bail also

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)

MIT License

84 stars 71 forks source link

Ensure that the git pre-processor doesn't accidentally bail also #128

Closed orta closed 2 years ago

orta commented 2 years ago

The refactor in #127 moved everything into the download path (as all API consumers would have to use that eventually) but self.preprocess_options can get called before that (and independently of it) and so this handles that case.

dnkoutso commented 2 years ago

For 1-6-stable?

orta commented 2 years ago

Yes, I'll fix rubocop after I get an old git to check

orta commented 2 years ago

Yep, good to go, confirmed the -- is ignored within a reasonable git range in an old linux vm: