[HTTP] Support apple disk image (*.dmg)

[manicmaniac]

Add support for libraries distributed in dmg file.

[orta]

This looks cool @manicmaniac - can we get some tests + CHANGELOG entries please?

[manicmaniac]

@orta Okay, I will try it.

@kylef Well, should I fix all these problems in this commit? Or create another PR?

@segiddins Thank you for advise, I will fix it.

[orta]

@manicmaniac feel free to make new commits, and push them to this branch, we will help you out.

[manicmaniac]

I wrote up some specs and fixed the problems. Now it passes unit tests except for 2 lint errors.

lib/cocoapods-downloader/http.rb:56:7: C: Perceived complexity for type_with_url is too high. [8/7] lib/cocoapods-downloader/http.rb:96:7: C: Method has too many lines. [26/24]

I'm afraid that it needs more drastic refactor to pass those lints...

[segiddins]

@manicmaniac so sorry for letting this languish, but if you rebase this, RuboCop should pass again :)

[segiddins]

hdiutil seems not to be installed on travis?

[neonichu]

I think the issue is that the cp-downloader specs aren't run on Travis OS X VMs: https://travis-ci.org/CocoaPods/cocoapods-downloader/jobs/76123291#L1

[manicmaniac]

hmm... there are 3 choices:

• send an email to Travis CI and enable the experimental multi OS feature ( os: osx )
• use a dirty hack ( language: objective-c )
• use a mock of hdiutil in a unit test

I think running Travis CI on OSX is troublesome. I will try the last one.

[kylef]

If I recall correctly, the multi OS feature was enabled for the CocoaPods organisation a while back.

[manicmaniac]

@kylef Still It seems to be running on Linux. Misconfiguration or misunderstanding?

[segiddins]

@kylef can you review this please? Somehow it slipped by us

[kylef]

The code changes seem fine to me, providing we want to add support for dmg this is :+1:.

[segiddins]

Thanks @manicmaniac, sorry for the delay in getting this merged.