search

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)
MIT License
84 stars 71 forks source link

Checkout submodules recursively #46

Closed neonichu closed 9 years ago

neonichu commented 9 years ago

We should checkout submodules recursively if the submodule option is true.

kylef commented 9 years ago

Makes sense, but maybe it would make sense to add --recursive to clone_arguments and do away with init_submodules entirely.

This is supported on git 1.6.5 and onwards

segiddins commented 9 years ago

:+1: with tests

neonichu commented 9 years ago

@kylef I think it is a good idea to not check out submodules by default, because they're probably dependencies and would just add time without any benefit

kylef commented 9 years ago

@neonichu They are not, and should not be by default. The recursive flag should only be added if options[:submodules].

neonichu commented 9 years ago

@kylef ah OK, I misunderstood your comment - that sounds like a better implementation, will change

segiddins commented 9 years ago

OK, this should be ready to :ship: