Adds check for whether directory is actually a bundle before moving children out

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)

MIT License

84 stars 72 forks source link

Adds check for whether directory is actually a bundle before moving children out #85

Closed 3sands closed 5 years ago

3sands commented 5 years ago

Checks whether post-uncompressed directory is a bundle. If so, do not move the contents out. #84

I don't know if this is an exhaustive list of extensions for bundles that masquerade as directories, but I wanted to put up at least a first pass at a solution that worked for at least some of them.

segiddins commented 5 years ago

I’m not sure I love this change — seems better to just specify flatten: false?

amorde commented 5 years ago

is that configurable in the Podspec? I'm not too familiar with this, but if something like this is possible then yes I agree

spec.source = {
    :http => 'some_url',
    :flatten => false
}

amorde commented 5 years ago

Going to close as the :flatten option is supported, so that can be used instead. Thanks!