CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)

MIT License

84 stars 72 forks source link

Force curl to use HTTP/1.1 #86

Open nrbrook opened 5 years ago

nrbrook commented 5 years ago

[x] I've read and understood the CONTRIBUTING guidelines and have done my best effort to follow.

Report

My podspec has a source zip on a server that supports HTTP/2. Curl 7.54.0 in the latest macOS 10.14.2 (18C54) has a bug which causes issues with files fetched over HTTP/2. Therefore my pod keeps failing to validate and install for users. I don't think there is a way in my podspec to provide flags to curl is there? Are there any other possible solutions?

dnkoutso commented 5 years ago

This is a change in cocoapods-downloader. Moving issue there.

endocrimes commented 5 years ago

I think the correct fix for this would be to only disable HTTP 2 when running with curl 7.54.0, but doing so in such case sgtm if macOS shipped a broken version.

nrbrook commented 5 years ago

That sounds good although it would also be useful to have an option on “source” for curl flags, but I’m just hoping for any solution at the moment as I don’t currently have one other than ‘keep trying’

nrbrook commented 5 years ago

Also other past (and future) versions of macOS might have this issue, 7.54.0 is not a very recent release, so it might be better just to disable http2 until Apple update curl

nrbrook commented 5 years ago

Or, better still, check the curl version not macOS version