Change interface

[fabiopelosin]

Change the interface to receive a single parameter and to output a single one:

require 'cocoapods-downloader'

input = Downloader::Configuration.new
input.target_path = './Downloads/MyDownload'
input.options = { :git => 'example.com' }
input.cache_root = '~/Library/Caches/APPNAME'
input.max_cache_size = 500

downloader = Pod::Downloader.for_target(input)
output = downloader.download
output.checkout_options #=> { :git => 'example.com', :commit => 'd7f410490dabf7a6bde665ba22da102c3acf1bd9' }

Considerations:

• The implicit contract with clients is clearer and favours the replacement of the class via Dependency injection in clients (CocoaPods).
• The checkout options should be always returned if applicable (this is internal logic of the downloader) in any case the operation is very fast and should not have an impact on performance.

@alloy I would love to hear your take when you have a minute.

[alloy]

Sounds good to me! The name should probably be something like Downloader::Configuration, though.

[fabiopelosin]

Y U don't like my naming :question:

[fabiopelosin]

:+1: btw

[fabiopelosin]

Given that the implementation was simplified and that the cache was removed, now I'm of the idea that even if I would now design the gem slightly differently the benefits would be minimal.