search

CocoaPods / cocoapods-downloader

A small library that provides downloaders for various source types (HTTP/SVN/Git/Mercurial)
MIT License
84 stars 71 forks source link

Don't convert branch name to commit hash #94

Closed Sjors closed 3 years ago

Sjors commented 4 years ago

I'm completely oblivious to rationale for #57, so sorry if this doesn't make any sense.

When a branch name is present, it's replaced by a git hash. This breaks shallow clones (as remarked by @simson2010 https://github.com/CocoaPods/cocoapods-downloader/pull/57#commitcomment-20566222.

It also makes git submodules even more painful, in particular when a branch points to a different origin than master. For example in https://github.com/Sjors/libwally-swift/commits/dev contains a submodule that points to a fork.

This PR removes the conversion from branch name to commit hash.

Sjors commented 4 years ago

I guess the trade-off here is between initial clone and updates? So maybe a better approach is possible

poxtyn1 commented 4 years ago

Iop

segiddins commented 4 years ago

This is a big breaking change, I don't think we're going to be able to merge it