search

CocoaPods / cocoapods.org

That website https://cocoapods.org/ - pretty useful
53 stars 47 forks source link

Pod official page redirected to homepage/github source page #457

Open dennycd opened 2 years ago

dennycd commented 2 years ago

Hi, one of our pod (https://cocoapods.org/pods/BoringSSL-GRPC) is always redirected to its homepage URL instead of landing on the official pod page on cocoapod. I noticed there are a number of similar reports having the same issues

https://github.com/CocoaPods/cocoapods.org/issues/448 https://github.com/CocoaPods/cocoapods.org/issues/443

Appreciate if anyone can help look into it

gammelby commented 2 years ago

We have the same issue for several pods, some listed in #390 - and https://cocoapods.org/pods/NabtoEdgeClientSwift, https://cocoapods.org/pods/NabtoEdgeClientApi.

pvenum commented 2 years ago

We are facing the same issue as well https://cocoapods.org/pods/OTXCFramework .

NachoSoto commented 2 years ago

Same is happening with https://cocoapods.org/pods/RevenueCat:

http -v https://cocoapods.org/pods/RevenueCat
GET /pods/RevenueCat HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: cocoapods.org
User-Agent: HTTPie/3.1.1.dev0

HTTP/1.1 302 Found
Age: 24
CF-Cache-Status: HIT
CF-RAY: 7141bb59da549450-SJC
Cache-Control: public, max-age=20, s-maxage=60
Connection: keep-alive
Content-Type: text/html;charset=utf-8
Date: Tue, 31 May 2022 18:21:53 GMT
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Location: https://www.revenuecat.com/
NEL: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
Report-To: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=gQOYSl3SrmYJAjy4g1R5cT0QPYowhZIZghpeF4gsOeadRhqOceni%2FDdEfj0iXTyTTwbugnBNM3LF7DWC%2F5xBO5RK0GiNwFFrLr1QnJiqXUOSi%2B3i9lZSBfDC9WNQSy8%3D"}],"group":"cf-nel","max_age":604800}
Server: cloudflare
Transfer-Encoding: chunked
Vary: Accept-Encoding
Via: 1.1 vegur
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 1; mode=block

This looks like a bug?

OriMedallia commented 1 year ago

Same https://cocoapods.org/pods/MDBannerViewSDK

narangkishore98 commented 1 year ago

Same https://cocoapods.org/pods/DotBar

gadphly commented 1 year ago

Any updates on this issue? We are seeing a similar problem for our project.

danielamitay commented 1 year ago

This is the root cause: https://github.com/CocoaPods/cocoapods.org/blob/master/app.rb#L114-L124

Essentially, if Cocoapods is not able to fetch the Github metrics (stargazers, etc) for whatever reason, it will simply redirect to the pod's homepage.

As far as I can tell, these metrics are no longer displayed anywhere in the Cocoapods pages, so ideally this check would simply be removed, as well as the metrics fetch/anything depending on it. I could be wrong about this still being in use though.

orta commented 1 year ago

The metrics in this case also includes things like the rendered readme/changelog, so there wouldn't be anything to render without that info! Those are generated by https://github.com/CocoaPods/cocoapods-metadata-service - so maybe the issue lays there

NachoSoto commented 1 year ago

@orta looks like https://github.com/CocoaPods/cocoapods-metadata-service/pull/24 might have been the fix? 🙏🏻 Are there any other errors that are still causing this?

orta commented 1 year ago

Yeah, it looks like about 20 times a day we hit this in the logs too:

2023-08-04T19:29:00.647873+00:00 heroku[router]: at=info method=POST path="/webhook/hooks/trunk host=cocoapods-metadata-service.herokuapp.com request_id=641f60b5-18bc-4d0a-9741-20558f4e302e fwd="18.208.148.102" dyno=web.1 connect=1ms service=2ms status=200 bytes=217 protocol=https

2023-08-04T19:29:02.132708+00:00 app[web.1]: [FunnelConnectSDK - 0.0.97] Getting info on README, CHANGELOG and community metrics.Uncaught error: error: syntax error at or near "WHERE"

so maybe not completely done