search

CocoaPods / fourflusher

A library for interacting with Xcode simulators.
MIT License
32 stars 15 forks source link

Update condition to work with new simulator JSON format #22

Closed colinhumber closed 5 years ago

colinhumber commented 5 years ago

Running xcrun simctl list -j after installing Xcode 11 shows the isAvailable check has a value of true now.

colinhumber commented 5 years ago

Fixes https://github.com/CocoaPods/fourflusher/issues/21

colinhumber commented 5 years ago

Oh shoot, yes of course!

colinhumber commented 5 years ago

@dnkoutso There was already a test in place for Xcode 10.2, which has the isAvailable: true in place already. Not sure how they were passing, but at any rate, added tests with the Xcode 11 setup.

dnkoutso commented 5 years ago

There was already a test in place for Xcode 10.2, which has the isAvailable: true in place already.

Where is it?

colinhumber commented 5 years ago

In the find_spec.rb starting on line 83. The sample JSON file has both availability and isAvailable included for each device.

dnkoutso commented 5 years ago

@colinhumber bundle exec rubocop -a to fix Rubocop CI error.

dnkoutso commented 5 years ago

@colinhumber ping

colinhumber commented 5 years ago

Sorry! I’ve been preoccupied at WWDC. I’ll take care of this this morning.

reececomo commented 5 years ago

👍 Awesome

colinhumber commented 5 years ago

Changes pushed

Coeur commented 5 years ago

@dnkoutso @colinhumber thank you both. It may sound precipitated, but as simply installing Xcode 11 immediately causes trouble to many users, I would suggest to not delay a release of fourflusher 2.3.0.

dnkoutso commented 5 years ago

Will release today.

dnkoutso commented 5 years ago

I am stupid. I should have asked to put this on 2-2-stable branch not master. Anyway will cherry-pick and fix and also add a CHANGELOG entry.

dnkoutso commented 5 years ago

Actually nm it will be 2.3.0.

dnkoutso commented 5 years ago

Released fourflusher 2.3.0 and added missing CHANGELOG entry.

dnkoutso commented 5 years ago

gem update fourflusher or bundle update fourflusher if using Bundler

Buju77 commented 5 years ago

awesome, thanks a lot for the quick fix and release! :)