CocoaPods / search.cocoapods.org

This is the CocoaPods search engine repo, please direct CocoaPods issues to the main CocoaPods repository.
25 stars 11 forks source link

Add SPM support in the search for queries #104

Closed orta closed 6 years ago

orta commented 8 years ago

Re: #103

I think this is the way to go, right @floere - a category which can be used to filter the results?

Note: you might want to review with ?w=1 on the URL, my editor ate a lot of whitespace. Note: to get bundle install to work on el cap, I had to make this, uncommitted change:

diff --git a/Gemfile.lock b/Gemfile.lock
index 1d13ec2..8523e30 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -51,7 +51,7 @@ GEM
     foreman (0.75.0)
       dotenv (~> 0.11.1)
       thor (~> 0.19.1)
-    google_hash (0.8.8)
+    google_hash (0.9.0)
       sane (~> 0)
     hashie (3.3.2)
     i18n (0.7.0)
@@ -165,4 +165,4 @@ DEPENDENCIES
   yajl-ruby

 BUNDLED WITH
-   1.10.5
+   1.11.2
czechboy0 commented 8 years ago

:blue_heart: :blue_heart: :blue_heart:

segiddins commented 8 years ago

/home/travis/build/CocoaPods/search.cocoapods.org/vendor/bundle/ruby/2.2.0/gems/flounder-1.0.1/lib/flounder/connection.rb:22:inexec': ERROR: column cocoadocs_pod_metrics.spm_support does not exist (PG::UndefinedColumn)`

orta commented 8 years ago

@floere poke - is this the right direction?

floere commented 8 years ago

@orta Thanks for the poke! I can check tonight 😊

On Mi., 16. März 2016 at 18:06 Orta

< mailto:Orta notifications@github.com

wrote:

https://github.com/floere poke - is this the right direction?

You are receiving this because you were mentioned.

Reply to this email directly or https://github.com/CocoaPods/search.cocoapods.org/pull/104#issuecomment-197428929 https://github.com/CocoaPods/search.cocoapods.org/pull/104#issuecomment-197428929

floere commented 8 years ago

@orta It is – but it depends what values are in spm_support…? Also, I'd not add too many qualifiers. :spm alone is enough, I'd say.

Also needed (for completeness' sake):

orta commented 8 years ago

spm_support is a bool in the db ( that has existed for a few months ) - I guess maybe the fixtures need updating?

czechboy0 commented 8 years ago

I'm really like to see this option added to the search API. Can I help out to accelerate this? 😊

orta commented 6 years ago

I've brought this back up to master, and I created the db dump, but I'm currently blocked on being able to upload it into the S3 bucket

orta commented 6 years ago

🥗

dnkoutso commented 6 years ago

This LGTM. Not sure if you want others to review who are more familiar.

floere commented 6 years ago

Nice work! 👍