CocoaPods / search.cocoapods.org

This is the CocoaPods search engine repo, please direct CocoaPods issues to the main CocoaPods repository.
25 stars 11 forks source link

Website search does not return all specs that 'pod search' does. #33

Closed atomkirk closed 11 years ago

atomkirk commented 11 years ago

There are many podspecs that don't come up in the website search, like 'ReactiveCocoa' or the 'Rebel' framework. But, they do show up in 'pod search reactive'

floere commented 11 years ago

Thanks for the pointer! http://cocoapods.org/?q=reactivecocoa comes up, but Rebel only returns an empty rendered result (that is then not shown) – possibly an error in the spec which the search engine discards (it needs to be failsafe). Let me see what I can do.

floere commented 11 years ago

Ok, when the search indexer is trying to load the Rebel.podspec file, the following error is thrown: Invalid 'Rebel.podspec' file: uninitialized constant Pod::FileList – it is using cocoapods-core (0.17.0.rc5).

@alloy @irrationalfab @Keithbsmiley Should the indexer load another CocoaPods gem or are we looking at outdated podspecs?

floere commented 11 years ago

36 pods currently raise this error.

fabiopelosin commented 11 years ago

I think that I forgot to require rake in CocoaPods-core (the FileList is deprecated but supported in 10.7). — Sent from Mailbox for iPhone

On Sun, Mar 24, 2013 at 10:44 AM, Florian R. Hanke notifications@github.com wrote:

36 pods currently raise this error.

Reply to this email directly or view it on GitHub: https://github.com/CocoaPods/cocoapods.org/issues/33#issuecomment-15353841

floere commented 11 years ago

@irrationalfab Does that mean we will require rake in core, then? Or should I require it in cocoapods.org?

keith commented 11 years ago

Sounds to me like we should require Rake until FileList is completely gone

floere commented 11 years ago

@Keithbsmiley I would agree. Can you do this and release?

keith commented 11 years ago

I included it https://github.com/CocoaPods/Core/commit/b234ad7a90212288aded9e09238d8e1820aa9fb4 but either @irrationalfab or @alloy will have to agree that's a good place to do that and it will get into the next update.

floere commented 11 years ago

Thanks! I am requiring rake for now to make the search run correctly and remove it again when the issue is resolved in core, or not – if we decide to not allow it.

@alloy or @irrationalfab Please ping me if you have updated infos so I can either remove rake or not.

floere commented 11 years ago

@atomkirk http://cocoapods.org/?q=rebel and http://cocoapods.org/?q=reactive. Cheers!

alloy commented 11 years ago

Yeah we should just have FileList work for now, but we probably need all of these monkey-patches as well? Which are now only available in the CocoaPods ‘client’ project.

fabiopelosin commented 11 years ago

@Keithbsmiley Good work, I included Rake as a dependency in the gemspec but I forgot to require it :-)

@alloy The monkey patches are needed only by the CocoaPods gem because the core never resolves the file patterns. The only thing that I think is missing is the declaration of the Pod::FileList in the core.

alloy commented 11 years ago

@irrationalfab You’re right.

fabiopelosin commented 11 years ago

I'm fixing it now.

fabiopelosin commented 11 years ago

Fixed by CocoaPods/Core f34dda7b9

floere commented 11 years ago

Just as an aside, http://cocoapods.org does not need Pod::FileList (Ruby resolves that).

Thanks guys! Released?

alloy commented 11 years ago

:heart: