search

CocoaPods / search.cocoapods.org

This is the CocoaPods search engine repo, please direct CocoaPods issues to the main CocoaPods repository.
25 stars 11 forks source link

Possible issues with special characters #48

Closed Kapeli closed 10 years ago

Kapeli commented 10 years ago

I'm not sure if this is by design or a bug, but I thought I should mention it anyways.

I've found issues with queries that contain _.

Example:

  1. Search on cocoapods.org for _.m -> nothing is found
  2. Search for .m -> _.m is correctly found
floere commented 10 years ago

Thanks! I was unaware that is allowed in pod names and will update the search engine to not reject .

floere commented 10 years ago

Note that this will be pushed as soon as we can push to Heroku again – there seem to be issues with the Ruby 2.1 buildpack.

floere commented 10 years ago

http://cocoapods.org/?q=_.m Cheers!

Kapeli commented 10 years ago

:+1: Thank you!

floere commented 10 years ago

My pleasure. Also, the API should generally be up unless I restart the server.

Kapeli commented 10 years ago

That's awesome news. Thank you!

floere commented 10 years ago

But the restarting bit really is important, so please add some UI pieces to handle the API being down.

Kapeli commented 10 years ago

If the API doesn't respond or the response is not valid JSON Dash will show a "Error: Could not connect to search.cocoapods.org. Try again in a few minutes." message.

Possible bug: while the API is down, searching on cocoapods.org's homepage does not show any feedback, it just fails silently.

floere commented 10 years ago

Yes, I have just thought today about how to handle "API down" errors. I'll think about it some more.

I'd suggest including the search link directly, i.e. cocoapods.org?q=text%20here