Closed k0nserv closed 10 years ago
@floere what do you think. I want to expose deprecation status as part of the returned data, but this requires new code from the Core. I tried running against Core master branch, but that seems to break a lot of the tests, I could of course fix these as a part of point the Core to the master branch too
@k0nserv - I think this makes sense, we'll need those Core changes around the others system too. So I'd make the change to master. @floere is away on holiday, so feel free to ping me or @alloy ( we don't know too much about search but can offer good advice probably ) if you have problems :+1:
@orta Okay I will update it to use the master branch for the Core and go through the failing tests and adjust them according to the changes in the core
The specs in tests broke when updating to 0.33.0
from my testing so far this is the diff between 0.33.0
and the previous version which was 0.32.1
. At row 39 in spec/api/flat_ids_integration_spec.rb the test fails because it no longer returns the pods MapBox
. @orta do you have anymore insight of what happened between 0.32.1
and 0.33.0
before I review the changes manually. I suspect that the following line(Gracefully handle unexpected source structure.
)(https://github.com/CocoaPods/Core/issues/110) in the Changelog might be related
Well, MapBox got deprecated, think that might be the reason?
Not sure, when it runs the test it uses the data
folder for the as the source to my understanding. Doing a grep -R deprecated spec/data
does not return anything related to MapBox so unless I am missing something I don't think that should affect it
This commit is what caused it to break https://github.com/CocoaPods/Core/commit/15a071e1be2cf9ba0f56ab3fe1dc8ac14f6bd9ec
It is indeed used by the MapBox pod as seen here. So should I remove that whole pod from the data folder then?
Yes! That makes sense to me.
Okay I did just that in #53 preparing the actual deprecation status PR right now by adding a few deprecated pods to the spec pods
Currently the Cocoapods Core version is not specifying the branch directly for the Core repository. Instead it's using the version available on RubyGems. Among other things this prevents overriding the gem with a local path. Is there are reason for it or should it be changed to use the same format as https://github.com/CocoaPods?